Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Refactor Flyout Design Updates #14

Merged
merged 2 commits into from
Dec 3, 2021
Merged

[Lens] Refactor Flyout Design Updates #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b0bd9a
allow flyout to go full width on small viewports
MichaelMarcialis Dec 3, 2021
69e99bd
remove hiding of layer panel when flyout open
MichaelMarcialis Dec 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions ...ugins/lens/public/editor_frame_service/editor_frame/config_panel/dimension_container.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,15 @@
// Use the EuiFlyout style
@include euiFlyout;
// But with custom positioning to keep it within the sidebar contents
position: absolute;
left: 0;
animation: euiFlyout $euiAnimSpeedNormal $euiAnimSlightResistance;
left: 0;
max-width: none !important;
z-index: $euiZContentMenu;

@include euiBreakpoint('l', 'xl') {
top: 0 !important;
height: 100% !important;
}

@include euiBreakpoint('xs', 's', 'm') {
@include euiFlyout;
left: 10vw;
z-index: $euiZContentMenu;
position: absolute;
top: 0 !important;
}

.lnsFrameLayout__sidebar-isFullscreen & {
Expand Down
7 changes: 1 addition & 6 deletions x-pack/plugins/lens/public/editor_frame_service/editor_frame/config_panel/layer_panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,12 +317,7 @@ export function LayerPanel(

return (
<>
<section
tabIndex={-1}
ref={registerLayerRef}
className="lnsLayerPanel"
style={{ visibility: isDimensionPanelOpen ? 'hidden' : 'visible' }}
>
<section tabIndex={-1} ref={registerLayerRef} className="lnsLayerPanel">
<EuiPanel data-test-subj={`lns-layerPanel-${layerIndex}`} paddingSize="none">
<header className="lnsLayerPanel__layerHeader">
<EuiFlexGroup gutterSize="s" responsive={false} alignItems="center">
Expand Down