fix: compile error with lifetime issues on optimize (#1843) #1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not even sure I understand what I'm doing here, but moving the code that transforms a stream of files into a stream of record batches into its own function with an explicit type signature apparently helps the compiler to properly understand the involved lifetimes. |
auto-merge was automatically disabled
November 13, 2023 20:38
Head branch was pushed to by a user without write access
dispanser
force-pushed
the
fix_lifetime_error
branch
from
21271ba
to
fde6be7
Compare
rtyler
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix compile error in main when not activating datafusion feature.
Related Issue(s)