Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Add -Bsymbolic linker flag to hide sqlite symbols #539

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

link2xt
Copy link
Contributor

@link2xt link2xt commented Mar 2, 2022

This prevents electron, which links against SQLite,
from overriding SQLCipher used in libdeltachat during dynamic linking.

Fixes #538

This prevents electron, which links against SQLite,
from overriding SQLCipher used in libdeltachat during dynamic linking.
@Simon-Laux
Copy link
Member

the export works now, I got an electron error which is probably unrealated, but I'll still post it here for reference:

[48279:0302/214110.712573:ERROR:vaapi_wrapper.cc(1123)] vaQuerySurfaceAttributes failed, VA error: invalid parameter
[48279:0302/214110.712733:ERROR:vaapi_wrapper.cc(1070)] FillProfileInfo_Locked failed for va_profile VAProfileH264Main and entrypoint VAEntrypointVLD
[48279:0302/214110.712776:ERROR:vaapi_wrapper.cc(1123)] vaQuerySurfaceAttributes failed, VA error: invalid parameter
[48279:0302/214110.712811:ERROR:vaapi_wrapper.cc(1070)] FillProfileInfo_Locked failed for va_profile VAProfileH264High and entrypoint VAEntrypointVLD

to be clear export worked on linux with this pr in both node and electron

@link2xt link2xt merged commit 7790de8 into master Mar 2, 2022
@link2xt link2xt deleted the symbolic-sqlcipher branch March 2, 2022 21:02
@dotlambda
Copy link
Contributor

dotlambda commented Mar 5, 2022

Signal added another flag, I don't know if that's something we also want: signalapp/better-sqlite3#3

@dotlambda
Copy link
Contributor

There is a related issue in the Matrix ecosystem: matrix-org/seshat#102

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exporting backup is broken
3 participants