Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for System.Text.Json #13

Merged
merged 13 commits into from
Sep 13, 2024

Conversation

eNeRGy164
Copy link
Member

@eNeRGy164 eNeRGy164 commented Sep 9, 2024

As remarked by @YVbakker in dendrodocs/dotnet-tool#19, investigated possibility to add support for System.Text.Json.
On first glance, this seems possible. Will need more test coverage for more confidence.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • Added tests to compare both implementations
  • Verified with using the PR build in the Tool

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@eNeRGy164 eNeRGy164 added the enhancement New feature or request label Sep 9, 2024
@eNeRGy164 eNeRGy164 self-assigned this Sep 9, 2024
@coveralls
Copy link

coveralls commented Sep 9, 2024

Pull Request Test Coverage Report for Build 10855403140

Details

  • 126 of 126 (100.0%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+26.1%) to 63.275%

Totals Coverage Status
Change from base Build 10854971307: 26.1%
Covered Lines: 391
Relevant Lines: 571

💛 - Coveralls

@eNeRGy164 eNeRGy164 merged commit 5be2ecd into dendrodocs:main Sep 13, 2024
1 check passed
@eNeRGy164 eNeRGy164 deleted the enable-system-text-json branch September 13, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants