Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A remote module which imports npm modules requires --unstable. #17455

Closed
dajiaji opened this issue Jan 17, 2023 · 4 comments · Fixed by #17889
Closed

A remote module which imports npm modules requires --unstable. #17455

dajiaji opened this issue Jan 17, 2023 · 4 comments · Fixed by #17889
Assignees
Labels
node compat question a question about the use of Deno

Comments

@dajiaji
Copy link

dajiaji commented Jan 17, 2023

Hi there.

Is there any plan to allow to use the remote module without --unstable?

@bartlomieju bartlomieju added question a question about the use of Deno node compat labels Jan 18, 2023
@bartlomieju
Copy link
Member

Currently there are no plans, we are still evaluating if this is actually desired.

@dajiaji
Copy link
Author

dajiaji commented Jan 18, 2023

I'm very glad if I can use the remote module importing npms without --unstable.

I've heard that Deno now supports npm modules, so I switched the primitive crypto library used in my E2E crypto module to an audited and fast npm module. As the result, using my module requires --unstable. This was not expected behavior at all. The biggest problem is that I cannot recognize this behavior on the local development environment.

I hope this behavior will be fixed.

@bartlomieju
Copy link
Member

@dsherret will work on that.

@dsherret
Copy link
Member

dsherret commented Jan 22, 2023

Task:

  • Review
    /// Resolves the npm package requirements from the graph attempting. The order
    • Edit: I remember now part of the reason for doing this was to help ensure you didn't get different resolution to occur based on where you entered in the graph, but maybe a lockfile handles this scenario well enough.

Edit 2: The deno_graph refactor simplifies npm specifier resolution to occur when the import is resolved and the order is based on how the specifier appears in the code. Resolution can be changed via an import map.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node compat question a question about the use of Deno
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants