fix(ext/node): Support returning tokens and option defaults in node:util.parseArgs
#23192
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23179.
Fixes #22454.
Enables passing
{tokens: true}
toparseArgs
and setting default values for options.With this PR, the observable framework works with deno out of the box (no unstable flags needed).
The existing code was basically copied straight from node, so this PR mostly just updates that (out of date) vendored code. Also fixes some issues with error exports (before this PR, in certain error cases we were attempting to construct error classes that weren't actually in scope).
The last change (in the second commit) adds a small hack so that we actually exercise the
test-parse-args.js
node_compat test, previously it was reported as passing though it should have failed. That test now passes.