Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upgrade): more informative information on invalid version #25319

Merged
merged 2 commits into from
Aug 31, 2024

Conversation

bartlomieju
Copy link
Member

Before:

$ deno upgrade v1.xx
error: Invalid version passed

After:

$ deno upgrade v1.xx
error: Invalid version passed (v1.xx)

Example usage:
  deno upgrade | deno upgrade 1.46 | deno upgrade canary

Screenshot 2024-08-31 at 01 21 30

Also updates help text to use "shorthand version" without flags, but a positional arg.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju enabled auto-merge (squash) August 30, 2024 23:55
@bartlomieju bartlomieju merged commit c29e5b9 into denoland:main Aug 31, 2024
17 checks passed
lucacasonato pushed a commit that referenced this pull request Sep 4, 2024
Before:
```
$ deno upgrade v1.xx
error: Invalid version passed
```

After:
```
$ deno upgrade v1.xx
error: Invalid version passed (v1.xx)

Example usage:
  deno upgrade | deno upgrade 1.46 | deno upgrade canary
```

Also updates help text to use "shorthand version" without flags, but a
positional arg.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants