Node process object compatibility
#3368
Conversation
rsp
force-pushed
the
node-process-compatibility
branch
from
35d0628
to
37bb133
Compare
| export const { pid, cwd, chdir, exit } = Deno; | ||
|
|
||
| export function on(_event: string, _callback: Function): void { | ||
| // TODO(rsp): to be implemented |
There was a problem hiding this comment.
please add
throw Error("unimplemented");
There was a problem hiding this comment.
Is it ok if I throw Error("unimplemented") for everything except "uncaughtException"? The idea is that Deno crashes on all uncaught exceptions anyway, and I want to prevent code that makes Node crash on uncaught exceptions to crash during adding a listener for uncaughtException.
There was a problem hiding this comment.
But it you think it's not a good idea then I can throw on everything and take care of it in a third party module, just let me know.
There was a problem hiding this comment.
Ok, I'm just throwing Error("unimplemented") for everything that is not actually implemented. I don't want to add any exceptions. Sorry for the confusion.
std/node/process.ts
Outdated
| // TODO(rsp): currently setting env seems to be working by modifying the object | ||
| // that is returnd by Deno.env(). Need to make sure that this is the final API | ||
| // or Deno.env('key', 'value') is to be used in the future. | ||
| export const env = Deno.env(); |
There was a problem hiding this comment.
Can you use a getter here? Otherwise everyone who imports this module will need to have --allow-env
There was a problem hiding this comment.
Ok, so you mean to give only a read access to the env? (I thought that --allow-env was needed to read the env as well, wasn't it?)
If so then I can either return a copy of the env as it was in the moment of reading, or use a Proxy to handle getting properties and throw on setting them?
There was a problem hiding this comment.
Oh, I think I know what you mean :) Never mind what I said, I apparently had too little sleep today.
rsp
force-pushed
the
node-process-compatibility
branch
from
9517249
to
7923317
Compare
|
Amazing, when the tests finally passed even on Windows, now the license/cla got stuck! Not my day. |
This PR adds a partial implementation of Node-compatible process:
process.cwd()process.chdir()process.versionprocess.versionsprocess.platformprocess.archprocess.pidprocess.on(no-op)process.argvprocess.envThis is very incomplete but should be sufficient for a library that I need to port to Deno that uses some of those to sniff for Node.
If it is ok to have a partial implementation for a good start then it's better to have it here, if not then let me know and I'll put it as a third-party module on deno.land/x
ref #2644