Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin all dependency versions, provide alpine-3.13 #152

Closed
mitranim opened this issue Aug 11, 2021 · 1 comment · Fixed by #153
Closed

Pin all dependency versions, provide alpine-3.13 #152

mitranim opened this issue Aug 11, 2021 · 1 comment · Fixed by #153

Comments

@mitranim
Copy link

Just spent a while headbutting weird CI failures. The ultimate solution was to rip apart and copy-paste alpine.dockerfile, but with the pinned version of FROM frolvlad/alpine-glibc:alpine-3.13. Because in this repo the dependency version is not pinned, newer images used 3.14 which caused weird edge case breakage in our build.

I'm not sure how this should be versioned. In our case, we want newer Deno but older Alpine. No specific recommendation here, just letting you know about the problem for now.
@wperron
Copy link
Contributor

wperron commented Aug 11, 2021

I have no issue just pinning the alpine version to 3.13, especially given that the distroless version uses a pinned 3.12 alpine as a pre-build step to download the deno binary.

wperron added a commit to wperron/deno-docker that referenced this issue Aug 11, 2021
@wperron
fix: use pined version for alpine
50ca8ad 
Make does not work with alpine 3.14, this commit pins the alpine version
to 3.13 to fix the issue.

Fixes denoland#152
wperron added a commit to wperron/deno-docker that referenced this issue Aug 11, 2021
@wperron
fix: use pined version for alpine
1e25984 
Make does not work with alpine 3.14, this commit pins the alpine version
to 3.13 to fix the issue.

Fixes denoland#152
@wperron wperron mentioned this issue Aug 11, 2021
Merged
wperron added a commit that referenced this issue Aug 11, 2021
@wperron
fix: use pinned version for alpine (#153)
641cc84 
Make does not work with alpine 3.14, this commit pins the alpine version
to 3.13 to fix the issue. The root cause seems to be [this issue][1] with
Alpine and Docker 20.10.5 and earlier. How this issue presents itself in
other container runtimes is unclear, but consensus seems to be that
reverting to alpine 3.13 fixes the issue.

[1] alpinelinux/docker-alpine#182

Fixes #152
@hayd hayd mentioned this issue Jan 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use pinned version for alpine wperron/deno-docker
2 participants
@mitranim @wperron