fix: do not cache unsupported origins in config #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lucacasonato
reviewed
Nov 7, 2021
There was a problem hiding this comment.
I feel like we might want to save the "No" when the user explicitly opts out by pressing "No". If they cancel though, we should do nothing. That way we won't prompt the user again about a specific registry once we eventually get around to re-fetching the manifest every 24 hours (the old extension did this).
|
@lucacasonato you are right... good catch, I will amend. |
|
Actually that is what it does. If you say And denoland/deno#9931 should address the reloading of not found origins daily. |
lucacasonato
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: denoland/deno#12621