fix(webdriverjs): use new headless argument to fix selenium-webdriver…

…@4.17.0 breaking release (#992) * fix(webdriverjs): use new headless argument to fix selenium-webdriver@4.17.0 breaking release * fix webdriverjs tests to use addArguments too * fix cli test * use --headless instead of --headless=new * use headless to reduce change diff
dequelabs · Jan 23, 2024 · 0daba98 · 0daba98
1 parent 2220400
commit 0daba98
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 10 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/cli/package.json b/packages/cli/package.json
@@ -52,7 +52,7 @@
     "chromedriver": "latest",
     "colors": "^1.4.0",
     "commander": "^9.4.1",
-    "selenium-webdriver": "^4.8.1"
+    "selenium-webdriver": "~4.17.0"
   },
   "devDependencies": {
     "@types/chai": "^4.3.3",

diff --git a/packages/cli/src/lib/webdriver.ts b/packages/cli/src/lib/webdriver.ts
@@ -15,7 +15,16 @@ const startDriver = async (
       config.chromedriverPath || chromedriver.path
     );
 
-    let options = new chrome.Options().headless();
+    let options = new chrome.Options();
+    // selenium-webdriver < 4.17.0
+    if (typeof options.headless === 'function') {
+      options.headless();
+    }
+    // selenium-webdriver >= 4.17.0
+    else {
+      options.addArguments('headless');
+    }
+
     if (config.chromeOptions?.length) {
       options = config.chromeOptions.reduce(function (options, arg) {
         return options.addArguments(arg);

diff --git a/packages/webdriverjs/test/test-utils.ts b/packages/webdriverjs/test/test-utils.ts
@@ -5,7 +5,7 @@ import chrome from 'selenium-webdriver/chrome';
 export const Webdriver = (): WebDriver => {
   const builder = new Builder()
     .forBrowser('chrome')
-    .setChromeOptions(new chrome.Options().headless())
+    .setChromeOptions(new chrome.Options().addArguments('headless'))
     .setChromeService(
       new chrome.ServiceBuilder(
         process.env.CHROMEDRIVER_PATH || chromedriver.path