Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(i18n): Add missing french rules translations #3919

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

KuSh
Copy link
Contributor

@KuSh KuSh commented Feb 21, 2023

French rules translation is missing new rules added recently

@KuSh KuSh requested a review from a team as a code owner February 21, 2023 16:20
@CLAassistant
Copy link

CLAassistant commented Feb 21, 2023

CLA assistant check
All committers have signed the CLA.

@straker
Copy link
Contributor

straker commented Feb 24, 2023

Thanks for the pr. We'll need to look for someone who speaks french that can review this, so might be a bit. But we'll make sure to get it merged.

Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for the contribution @KuSh

For the books: Reviewed for security.

@WilcoFiers WilcoFiers merged commit 8557f3e into dequelabs:develop Aug 21, 2023
15 of 17 checks passed
@KuSh KuSh deleted the patch-2 branch August 21, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants