feat(checks): enable help-same-as-label, but remove from rules #4096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
approved these changes
Jul 24, 2023
Merged
Merged
7 tasks
v-viyada
added a commit
to microsoft/accessibility-insights-web
that referenced
this pull request
Apr 25, 2024
#### Details This PR updates axe-core to its latest version, [4.8.4](https://github.com/dequelabs/axe-core/releases/v4.8.4), from [4.7.2](https://github.com/dequelabs/axe-core/releases/v4.7.2). It also bumps the accessibility-insights-report package version. As part of the axe-core update: - The deprecate & disable duplicate-id / duplicate-id-active rule has been deprecated (dequelabs/axe-core#4071). - moved duplicate-id-aria to needs review. (dequelabs/axe-core#4075) <img width="922" alt="image" src="https://github.com/microsoft/accessibility-insights-web/assets/95463767/152c51ce-16d9-4550-aee2-6ddd8155a722"> - checks: enable help-same-as-label, but remove from rules (dequelabs/axe-core#4096) - Various improvements were made to the types. Potentially the most impactful of which is that the target and ancestry property now return as UnlabelledFrameSelector instead of as string[], - Major version upgrade 4.8.0 details https://github.com/dequelabs/axe-core/releases/tag/v4.8.0 <!-- Usually a sentence or two describing what the PR changes --> ##### Motivation This change is part of https://dev.azure.com/mseng/1ES/_workitems/edit/2157659/ ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [ ] Addresses an existing issue: #0000 - [ ] Ran `yarn fastpass` - [x] Added/updated relevant unit test(s) (and ran `yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [ ] (UI changes only) Added screenshots/GIFs to description above - [ ] (UI changes only) Verified usability with NVDA/JAWS --------- Co-authored-by: Rakesh Shivapooja <v-rakeshsh@microsoft.com> Co-authored-by: Vikash Yadav <v-viyada@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
help-same-as-labelcheck from thelabelandselect-namerules. Since this check was off by default, it didn't do anything. This fixes that the rule-description.md file incorrectly indicated these rules could report impact asminor. Removing the check from this rule means it can be enabled again as well.Closes: #1325