Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(color-contrast): ignore zero width characters #4103

Merged
merged 4 commits into from
Aug 7, 2023

Conversation

straker
Copy link
Contributor

@straker straker commented Jul 24, 2023

I grabbed the Affirm font from the provided website. I couldn't figure out how to generate a font that had 0 width characters so I hope it's OK for us to grab it for test purposes.

Closes: #3918

@straker straker requested a review from a team as a code owner July 24, 2023 21:54
lib/commons/text/is-icon-ligature.js Show resolved Hide resolved
test/assets/Affirm.woff Outdated Show resolved Hide resolved
dbjorge
dbjorge previously approved these changes Aug 7, 2023
Copy link
Contributor

@dbjorge dbjorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated inline with a non-copyright-encumbered custom font per our discussion offline. Minor suggestion on one of the new comments, otherwise LGTM!

lib/commons/text/is-icon-ligature.js Outdated Show resolved Hide resolved
Co-authored-by: Dan Bjorge <dan.bjorge@deque.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

color-contrast check: getImageData fails with value is not of type long
3 participants