Adds support for weekStartsOn and prettier config #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derhuerst
requested changes
Apr 13, 2022
| ['endOfWeek', dt => dt.endOf('week')] | ||
| ]) | ||
|
|
||
| const createParse = (DateTime) => { | ||
| const createParse = DateTime => { | ||
| const parseHumanRelativeTime = (str, now = DateTime.local()) => { |
There was a problem hiding this comment.
Please give the Luxor parseHumanRelativeTime variant the same signature as the date-fns variant, by adding opt = {}.
| const parseHumanRelativeTime = ( | ||
| str, | ||
| now = new Date(), | ||
| opts = {weekStartsOn: 0} |
There was a problem hiding this comment.
Suggested change
| opts = {weekStartsOn: 0} | |
| opts = {} |
| str, | ||
| now = new Date(), | ||
| opts = {weekStartsOn: 0} | ||
| ) => { | ||
| const instructions = lex(str) |
There was a problem hiding this comment.
Suggested change
| const instructions = lex(str) | |
| const { | |
| weekStartsOn, | |
| } = { | |
| weekStartsOn: 0, | |
| ...opt, | |
| } | |
| const instructions = lex(str) |
|
Also, would you mind adding a test case? Thanks! |
|
@binarykitchen Ping, in case you want to clean this up a bit. 🙂 I'd be happy to merge it afterwards! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4