Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with FFMPEG 7.0 #128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eclipseo
Copy link

avutil: remove deprecated FF_API_REORDERED_OPAQUE

Ref: FFmpeg/FFmpeg@67e7f0b

avutil: remove deprecated FF_API_REORDERED_OPAQUE

Ref: FFmpeg/FFmpeg@67e7f0b
@ilya-fedin
Copy link
Contributor

ilya-fedin commented Jun 14, 2024

This perhaps should have some replacement code rather than just commented out with 7.0+? How did upstream webrtc solve that?

@wRAR
Copy link

wRAR commented Sep 3, 2024

https://webrtc.googlesource.com/src/+/e7d10047096880feb5e9846375f2da54aef91202%5E%21/

The usage of the field in webrtc seems only to be for sanity checking, so it should be just safe to remove entirely, since webrtc does not expect re-ordering at all.

@ilya-fedin
Copy link
Contributor

ilya-fedin commented Sep 3, 2024

Ok, please replace the patch with a cherry-pick of the upstream one.

The title of the PR also sounds too loud, fixing the build usually doesn't mean adding compatibility. It usually doesn't work even after it builds and I think I heard some complains about runtime crashes with ffmpeg 7. So there's likely way more work needed for real compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants