Add cmake option to load h264 library with dlopen #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzhao9
force-pushed
the
xz9/dlopen-h264
branch
4 times, most recently
from
0342ae2
to
1da7239
Compare
xuzhao9
force-pushed
the
xz9/dlopen-h264
branch
from
1da7239
to
c985d2e
Compare
xuzhao9
changed the title
xuzhao9
changed the title
|
This fork only maintains cmake build. Such patches have to be supplied to the upstream located at https://webrtc.googlesource.com/src/. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux Distributions like openSUSE does not bundle open source H264 encoder/decoder due to licensing issues: https://news.opensuse.org/2023/01/24/opensuse-simplifies-codec-install/. The distribution developers suggested to use the "dlopen" mode to load H264 symbols at runtime, similiar to libfreerdp: https://github.com/FreeRDP/FreeRDP/blob/master/libfreerdp/codec/h264_openh264.c
This PR adds a compile option
TG_OWT_DLOPEN_H264to usedlopen()and load H264 library at runtime instead of at compile time.