Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't emit code that relies on importing external helpers #596

Merged
merged 6 commits into from
May 1, 2020

Conversation

developit
Copy link
Owner

Currently, transpiling for await (..) produces output that looks like this:

import { _finallyRethrows, _catch, _for } from 'babel-plugin-transform-async-to-promises/helpers';

// <snip>
        const _temp5 = _finallyRethrows(function () {
          return _catch(function () {
            _iterator = _asyncIterator(json);
// <snip>

This is a bug, since most folks don't have babel-plugin-transform-async-to-promises in their project dependencies and aren't expecting bundles to depend on it.

@developit developit merged commit bec46e6 into master May 1, 2020
@developit developit deleted the async-to-promises-helpers branch May 1, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant