TS: Fix Fragments broken when jsxFactory is set #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developit
approved these changes
May 20, 2020
|
@marvinhagemeister hopefully we'll fix this in Typescript very soon microsoft/TypeScript#38720 |
|
@nojvek That would be a dream come true! Thank you so much for picking this up 🙌 |
mdespuits
pushed a commit
to cision/rover-ui
that referenced
this pull request
May 27, 2020
developit/microbundle#623 A known issue in TypeScript: microsoft/TypeScript#20469
mdespuits
added a commit
to cision/rover-ui
that referenced
this pull request
May 27, 2020
* Use Babel plugins to fix Fragments issue developit/microbundle#623 A known issue in TypeScript: microsoft/TypeScript#20469 * Remove default mention. It's not accurate here
bors bot
pushed a commit
that referenced
this pull request
Mar 3, 2022
#809 (comment) I removed the `options.jsx === 'React.createElement'` thing as it's no longer relevant with `jsxFragmentFactory` (see #623 (comment)) and we set default values in the CLI for both `jsx` and `jsxFragment`, so we don't really need extra fallback values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript is unable to resolve Fragments when the
jsxFactoryoption is set. This is a known issue for years at the TypeScript project. But the problem is that it will still break, even when you set it to the default value 🤷Fixes #622