NNS1-3348 display public neuron badge #5500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coskucinkilic
force-pushed
the
NNS1-3348-display-public-neuron-badge
branch
from
ff223fd
to
c90ef7d
Compare
We want to pull in the latest changes. * Ran `npm run update:gix` * CI should pass * The pulled in changes should have been tested before being committed to their repositories. Co-authored-by: gix-bot <gix-bot@users.noreply.github.com>
# Motivation We want to pull in the latest changes. # Changes * Ran `npm run upgrade:next` # Tests * CI should pass * The pulled in changes should have been tested before being committed to their repositories. Co-authored-by: gix-bot <gix-bot@users.noreply.github.com>
…5501) # Motivation A newer release of the internet computer is available. We want to keep our Cargo dependencies up to date. # Changes * Ran `scripts/update-ic-cargo-deps` to update the Cargo.toml dependencies to the latest IC release. # Tests * See CI Co-authored-by: gix-bot <gix-bot@users.noreply.github.com>
# Motivation
We would like to render all the latest proposal types.
Even with no changes, just updating the reference is good practice.
# Changes
* Update the version of `IC_COMMIT_FOR_PROPOSALS` specified in
`dfx.json`.
* Updated the `proposals` candid files to the versions in that commit.
* Updated the Rust code derived from `.did` files in the proposals
payload rendering crate.
# Tests
- [ ] Please check the API updates for any breaking changes that affect
our code.
- [ ] Please check for new proposal types and add tests for them.
Breaking changes are:
* New mandatory fields
* Removing mandatory fields
* Renaming fields
* Changing the type of a field
* Adding new variants
Co-authored-by: gix-bot <gix-bot@users.noreply.github.com>
coskucinkilic
force-pushed
the
NNS1-3348-display-public-neuron-badge
branch
from
40a92ad
to
36dd7de
Compare
…3348-display-public-neuron-badge
…3348-display-public-neuron-badge
coskucinkilic
force-pushed
the
NNS1-3348-display-public-neuron-badge
branch
from
b1381bd
to
780952e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make public neurons easily identifiable
Changes
Add IconPublicBadge and Tooltip
Add isNeuronVisibilityPublic neuron util and related tests
Update tableNeuronsFromNeuronInfos to include isPublic which derives from neuroninfo.visibility
Update NeuronIdCell page object
screenshots:
Tests
Tests has been added for new utils, and display of the badge and tooltip text
No e2e tests because currently you cannot create a public neuron.
Todos
Not necessary