Fix failing tests

dgieselaar · Jul 29, 2023 · 1255cf1 · 1255cf1
1 parent d695a70
commit 1255cf1
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 13 deletions.
diff --git a/x-pack/plugins/observability_ai_assistant/public/hooks/use_chat.test.ts b/x-pack/plugins/observability_ai_assistant/public/hooks/use_chat.test.ts
@@ -95,12 +95,16 @@ describe('useChat', () => {
     mockResponse(Promise.reject(new Error()));
     const { result, waitFor } = renderHook(() => useChat());
 
+    const catchMock = jest.fn();
+
     act(() => {
-      result.current.generate({ messages: [], connectorId: 'myConnectorId' });
+      result.current.generate({ messages: [], connectorId: 'myConnectorId' }).catch(catchMock);
     });
 
     await waitFor(() => result.current.loading === false, WAIT_OPTIONS);
 
+    expect(catchMock).toHaveBeenCalled();
+
     expect(result.current.error).toBeInstanceOf(Error);
     expect(result.current.content).toBeUndefined();
 
@@ -122,7 +126,7 @@ describe('useChat', () => {
     const { result, waitFor } = renderHook(() => useChat());
 
     act(() => {
-      result.current.generate({ messages: [], connectorId: 'myConnectorId' });
+      result.current.generate({ messages: [], connectorId: 'myConnectorId' }).catch(() => {});
     });
 
     await waitFor(() => result.current.loading === false, WAIT_OPTIONS);
@@ -168,15 +172,15 @@ describe('useChat', () => {
     const { result, waitFor } = renderHook(() => useChat());
 
     act(() => {
-      result.current.generate({ messages: [], connectorId: 'myConnectorId' });
+      result.current.generate({ messages: [], connectorId: 'myConnectorId' }).catch(() => {});
     });
 
     await waitFor(() => result.current.content === 'foo', WAIT_OPTIONS);
 
     mockDeltas([{ content: 'bar' }]);
 
     act(() => {
-      result.current.generate({ messages: [], connectorId: 'myConnectorId' });
+      result.current.generate({ messages: [], connectorId: 'myConnectorId' }).catch(() => {});
     });
 
     await waitFor(() => result.current.loading === false, WAIT_OPTIONS);
@@ -230,7 +234,7 @@ describe('useChat', () => {
     const { result, waitForNextUpdate } = renderHook(() => useChat());
 
     act(() => {
-      result.current.generate({ messages: [], connectorId: 'myConnectorId' });
+      result.current.generate({ messages: [], connectorId: 'myConnectorId' }).catch(() => {});
     });
 
     await waitForNextUpdate(WAIT_OPTIONS);
@@ -258,14 +262,14 @@ describe('useChat', () => {
     const { result, waitForNextUpdate } = renderHook(() => useChat());
 
     act(() => {
-      result.current.generate({ messages: [], connectorId: 'myConnectorId' });
+      result.current.generate({ messages: [], connectorId: 'myConnectorId' }).catch(() => {});
     });
 
     await waitForNextUpdate(WAIT_OPTIONS);
 
     act(() => {
       mockDeltas([{ content: 'bar' }]);
-      result.current.generate({ messages: [], connectorId: 'mySecondConnectorId' });
+      result.current.generate({ messages: [], connectorId: 'mySecondConnectorId' }).catch(() => {});
     });
 
     await waitForNextUpdate(WAIT_OPTIONS);

diff --git a/x-pack/plugins/observability_ai_assistant/public/service/create_service.test.ts b/x-pack/plugins/observability_ai_assistant/public/service/create_service.test.ts
@@ -4,9 +4,9 @@
  * 2.0; you may not use this file except in compliance with the Elastic License
  * 2.0.
  */
-import { CoreSetup } from '@kbn/core/public';
+import type { CoreStart } from '@kbn/core/public';
 import { ReadableStream } from 'stream/web';
-import { ObservabilityAIAssistantService } from '../types';
+import type { ObservabilityAIAssistantService } from '../types';
 import { createService } from './create_service';
 
 describe('createService', () => {
@@ -44,7 +44,7 @@ describe('createService', () => {
         http: {
           post: httpPostSpy,
         },
-      } as unknown as CoreSetup);
+      } as unknown as CoreStart);
     });
 
     afterEach(() => {

diff --git a/x-pack/plugins/observability_ai_assistant/public/service/create_service.ts b/x-pack/plugins/observability_ai_assistant/public/service/create_service.ts
@@ -5,15 +5,15 @@
  * 2.0.
  */
 
-import type { CoreSetup, HttpResponse } from '@kbn/core/public';
+import type { CoreStart, HttpResponse } from '@kbn/core/public';
 import { filter, map } from 'rxjs';
 import type { Message } from '../../common';
 import { createCallObservabilityAIAssistantAPI } from '../api';
 import type { CreateChatCompletionResponseChunk, ObservabilityAIAssistantService } from '../types';
 import { readableStreamReaderIntoObservable } from '../utils/readable_stream_reader_into_observable';
 
-export function createService(coreSetup: CoreSetup): ObservabilityAIAssistantService {
-  const client = createCallObservabilityAIAssistantAPI(coreSetup);
+export function createService(coreStart: CoreStart): ObservabilityAIAssistantService {
+  const client = createCallObservabilityAIAssistantAPI(coreStart);
 
   return {
     isEnabled: () => {