fix(vector): fix index rebuild when options change

posting/index.go

@@ -1218,14 +1218,22 @@ func (rb *IndexRebuild) needsTokIndexRebuild() *indexRebuildInfo {
 	prevFactoryNames := make(map[string]struct{})
 	prevFactories := make(map[string]*pb.VectorIndexSpec)
 	for _, t := range old.IndexSpecs {
-		prevFactoryNames[t.Name] = struct{}{}
-		prevFactories[t.Name] = t
+		spec, err := tok.GetFactoryCreateSpecFromSpec(t)
+		x.AssertTruef(err == nil, "Error while building index spec %s", err)
+		name := spec.Name()
+
+		prevFactoryNames[name] = struct{}{}
+		prevFactories[name] = t
 	}
 	currFactoryNames := make(map[string]struct{})
 	currFactories := make(map[string]*pb.VectorIndexSpec)
 	for _, t := range rb.CurrentSchema.IndexSpecs {
-		currFactoryNames[t.Name] = struct{}{}
-		currFactories[t.Name] = t
+		spec, err := tok.GetFactoryCreateSpecFromSpec(t)
+		x.AssertTruef(err == nil, "Error while building index spec %s", err)
+		name := spec.Name()
+
+		currFactoryNames[name] = struct{}{}
+		currFactories[name] = t
 	}
 
 	newFactoryNames, deletedFactoryNames := x.Diff(currFactoryNames, prevFactoryNames)
@@ -1532,13 +1540,37 @@ func (rb *IndexRebuild) needsVectorIndexEdgesRebuild() indexOp {
 	prevIndex := old.Directive == pb.SchemaUpdate_INDEX &&
 		old.ValueType == pb.Posting_VFLOAT
 
+	prevFactoryNames := make(map[string]struct{})
+	prevFactories := make(map[string]*pb.VectorIndexSpec)
+	for _, t := range old.IndexSpecs {
+		spec, err := tok.GetFactoryCreateSpecFromSpec(t)
+		x.AssertTruef(err == nil, "Error while building index spec %s", err)
+		name := spec.Name()
+
+		prevFactoryNames[name] = struct{}{}
+		prevFactories[name] = t
+	}
+
+	currFactoryNames := make(map[string]struct{})
+	currFactories := make(map[string]*pb.VectorIndexSpec)
+	for _, t := range rb.CurrentSchema.IndexSpecs {
+		spec, err := tok.GetFactoryCreateSpecFromSpec(t)
+		x.AssertTruef(err == nil, "Error while building index spec %s", err)
+		name := spec.Name()
+
+		currFactoryNames[name] = struct{}{}
+		currFactories[name] = t
+	}
+
+	newFactoryNames, deletedFactoryNames := x.Diff(currFactoryNames, prevFactoryNames)
+
 	// If the schema directive did not change, return indexNoop.
-	if currIndex == prevIndex {
+	if currIndex == prevIndex && len(newFactoryNames) == 0 && len(deletedFactoryNames) == 0 {
 		return indexNoop
 	}
 
 	// If the current schema requires an index, index should be rebuilt.
-	if currIndex {
+	if currIndex || len(newFactoryNames) != 0 {
 		return indexRebuild
 	}
 	// Otherwise, index should only be deleted.

tok/hnsw/persistent_factory.go

@@ -19,6 +19,7 @@
 package hnsw
 
 import (
+	"fmt"
 	"sync"
 
 	c "github.com/dgraph-io/dgraph/v24/tok/constraints"
@@ -80,6 +81,9 @@ func (hf *persistentIndexFactory[T]) AllowedOptions() opt.AllowedOptions {
 		AddIntOption(EfConstructionOpt).
 		AddIntOption(EfSearchOpt)
 	getSimFunc := func(optValue string) (any, error) {
+		if optValue != Euclidian && optValue != Cosine && optValue != DotProd {
+			return nil, errors.New(fmt.Sprintf("Can't create a vector index for %s", optValue))
+		}
 		return GetSimType[T](optValue, hf.floatBits), nil
 	}