Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade etcd/raft to v3 #7688

Merged
merged 1 commit into from
Aug 22, 2023
Merged

chore: upgrade etcd/raft to v3 #7688

merged 1 commit into from
Aug 22, 2023

Conversation

NamanJain8
Copy link
Contributor

@NamanJain8 NamanJain8 commented Apr 6, 2021 •
edited by mangalaman93
Loading

No description provided.

@rohanprasad rohanprasad marked this pull request as ready for review June 2, 2021 17:53
jarifibrahim
jarifibrahim reviewed Jun 3, 2021
View reviewed changes
Copy link
Contributor

@jarifibrahim jarifibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs a description.
@rohanprasad Isn't this a breaking change for us? Is this change backward compatible?

@rohanprasad rohanprasad changed the title chore(pkg): upgrade etcd/raft to v3 chore(pkg): [Breaking] upgrade etcd/raft to v3 Jun 7, 2021
@NamanJain8 NamanJain8 changed the title chore(pkg): [Breaking] upgrade etcd/raft to v3 chore(pkg): [Maybe Breaking] upgrade etcd/raft to v3 Jun 8, 2021
@NamanJain8 NamanJain8 mentioned this pull request Jun 8, 2021
Closed
@NamanJain8 NamanJain8 mentioned this pull request Jul 14, 2021
Merged
@broglea broglea mentioned this pull request Feb 10, 2022
Merged
@CLAassistant
Copy link

CLAassistant commented Apr 29, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mangalaman93 mangalaman93 changed the base branch from master to main August 18, 2023 05:42
@mangalaman93 mangalaman93 force-pushed the naman/etcd-upgrade branch 3 times, most recently from 5c514e6 to c34d3a3 Compare August 18, 2023 05:45
@mangalaman93 mangalaman93 changed the title chore(pkg): [Maybe Breaking] upgrade etcd/raft to v3 chore: upgrade etcd/raft to v3 Aug 18, 2023
harshil-goel
harshil-goel previously approved these changes Aug 18, 2023
View reviewed changes
mangalaman93
mangalaman93 previously approved these changes Aug 18, 2023
View reviewed changes
@mangalaman93 mangalaman93 merged commit 39f1535 into main Aug 22, 2023
12 checks passed
@mangalaman93 mangalaman93 deleted the naman/etcd-upgrade branch August 22, 2023 15:22
shivaji-dgraph added a commit that referenced this pull request Mar 12, 2024
@shivaji-dgraph @NamanJain8 @mangalaman93
chore: upgrade etcd/raft to v3 (#7688) (#52)
a4cd4fe 
cherry picked from commit
39f1535

Co-authored-by: Naman Jain <naman@dgraph.io>
Co-authored-by: Aman Mangal <aman@dgraph.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mangalaman93 mangalaman93 mangalaman93 left review comments

@jarifibrahim jarifibrahim jarifibrahim left review comments

@all-seeing-code all-seeing-code all-seeing-code approved these changes

@harshil-goel harshil-goel harshil-goel approved these changes

@manishrjain manishrjain Awaiting requested review from manishrjain

@vvbalaji-dgraph vvbalaji-dgraph Awaiting requested review from vvbalaji-dgraph

@meghalims meghalims Awaiting requested review from meghalims

@sanjayk-github-dev sanjayk-github-dev Awaiting requested review from sanjayk-github-dev

@billprovince billprovince Awaiting requested review from billprovince

@joshua-goldstein joshua-goldstein Awaiting requested review from joshua-goldstein

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@NamanJain8 @CLAassistant @mangalaman93 @all-seeing-code @jarifibrahim @harshil-goel