fix(restore): Do not retry restore proposal #8058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manishrjain
approved these changes
Sep 30, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ahsanbarkati)
mangalaman93
pushed a commit
that referenced
this pull request
Oct 17, 2023
Do not retry the restore proposal. It can cause issues in
the edge case scenarios. Consider the following scenario:
1. alpha-2 gets the restore request (leader is alpha-0)
2. alpha-2 sends the request to alpha-0 (leader).
3. alpha-0 called proposeAndWait which proposed the req
(index 24) at time=15:56:10
4. alpha-0 was still waiting for the proposal to be applied
and RPC call for `Restore` by alpha-2 got "transport
closing error" at time=15:59:08
5. transport closing is a retriable error, so alpha-2 again
tried to proposeoOrSend, this time leader was alpha-1,
so it sent it to alpha-1
6. alpha-1 proposed the restore request (index 28) at time=15:59:09
mangalaman93
added a commit
that referenced
this pull request
Oct 17, 2023
Do not retry the restore proposal. It can cause issues in
the edge case scenarios. Consider the following scenario:
1. alpha-2 gets the restore request (leader is alpha-0)
2. alpha-2 sends the request to alpha-0 (leader).
3. alpha-0 called proposeAndWait which proposed the req
(index 24) at time=15:56:10
4. alpha-0 was still waiting for the proposal to be applied
and RPC call for `Restore` by alpha-2 got "transport
closing error" at time=15:59:08
5. transport closing is a retriable error, so alpha-2 again
tried to proposeoOrSend, this time leader was alpha-1,
so it sent it to alpha-1
6. alpha-1 proposed the restore request (index 28) at time=15:59:09
mangalaman93
added a commit
that referenced
this pull request
Mar 13, 2024
Do not retry the restore proposal. It can cause issues in the edge case scenarios. Consider the following scenario: 1. alpha-2 gets the restore request (leader is alpha-0) 2. alpha-2 sends the request to alpha-0 (leader). 3. alpha-0 called proposeAndWait which proposed the req (index 24) at time=15:56:10 4. alpha-0 was still waiting for the proposal to be applied and RPC call for `Restore` by alpha-2 got "transport closing error" at time=15:59:08 5. transport closing is a retriable error, so alpha-2 again tried to proposeoOrSend, this time leader was alpha-1, so it sent it to alpha-1 6. alpha-1 proposed the restore request (index 28) at time=15:59:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue caused due to retry of restore proposal, consider the following scenario:
This PR removes the retry logic. If the restore fails, it should be re-triggered manually.
This change is