Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alpha): support RDF response via http query request (#8004) #8639

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

all-seeing-code
Copy link
Contributor

@all-seeing-code all-seeing-code commented Jan 30, 2023

Fixes #8529
Closes: DGRAPHCORE-223

inspired from #8004

@CLAassistant
Copy link

CLAassistant commented Jan 30, 2023

CLA assistant check
All committers have signed the CLA.

@MichelDiz MichelDiz added the dgraph Issue or PR created by an internal Dgraph contributor. label Mar 7, 2023
@mangalaman93 mangalaman93 force-pushed the anurag/cp-rdf-over-http branch 2 times, most recently from 4f6a4dd to 10aa259 Compare May 17, 2023 20:43
@mangalaman93 mangalaman93 changed the title Anurag/cp rdf over http feat(http): Support RDF response via http query request (#8004) May 17, 2023
@mangalaman93 mangalaman93 marked this pull request as ready for review May 17, 2023 20:45
@mangalaman93 mangalaman93 force-pushed the anurag/cp-rdf-over-http branch 2 times, most recently from dcea048 to 8c32893 Compare May 17, 2023 20:53
@mangalaman93 mangalaman93 changed the title feat(http): Support RDF response via http query request (#8004) feat(alpha): support RDF response via http query request (#8004) Jul 28, 2023
mangalaman93
mangalaman93 previously approved these changes Jul 28, 2023
Copy link
Contributor

@sanjayk-github-dev sanjayk-github-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM

MichelDiz
MichelDiz previously approved these changes Jul 29, 2023
Copy link
Contributor

@MichelDiz MichelDiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The response looks good

{
    "data":"<0x1> <name> \"Bob \\\"\\u003cthe builder\\u003e\\\"\" .\n<0x1> <balance> \"110\" .\n"
}

dgraph/cmd/alpha/http_test.go Outdated Show resolved Hide resolved
@mangalaman93 mangalaman93 dismissed stale reviews from MichelDiz, sanjayk-github-dev, and themself via 53b43c2 July 29, 2023 04:37
@mangalaman93 mangalaman93 merged commit 48b1d5f into main Jul 31, 2023
11 checks passed
@mangalaman93 mangalaman93 deleted the anurag/cp-rdf-over-http branch July 31, 2023 03:02
jbhamra1 pushed a commit that referenced this pull request Aug 17, 2023
Fixes #8529
Closes: DGRAPHCORE-223

inspired from #8004

Co-authored-by: Aman Mangal <aman@dgraph.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dgraph Issue or PR created by an internal Dgraph contributor.
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT]: Add support for rdf response via http
5 participants