We don't need to use govendor in Docker. All the deps are checked in. #87

manishrjain · 2016-05-17T07:45:59Z

This change is

pawanrawal · 2016-05-17T08:13:08Z

Previously, manishrjain (Manish R Jain) wrote…

We don't need to use govendor in Docker. All the deps are checked in.

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@filter

Currently when we have a language tagged predicate (example: name). Querying name should return only untagged values. name@. should return any language. Consider dataset <1> <name> "first user" . <2> <name@en> "second user" . query (func: uid(1,2)) { uid name} would return "{uid: 1, name: first user}". query (func: uid(1,2)) { uid name@.} would return "{{uid: 1, name@.: "first user"}, {uid: 2, name@.: "second user"}}". However due to a bug, we are not enforcing this in @filter(has(name)). So this results in query (func: has(dgraph.type)) @filter(has(name)) { uid name} results in "{{uid: 1, name: "first user'}, {uid: 2}}" Fix: We update @filter(has(name)) to filter on basis of language. Fixes: https://linear.app/hypermode/issue/HYP-311/inconsistent-counts-using-has-at-root --------- Co-authored-by: Harshil Goel <harshil@dgraph.io>

@filter

Currently when we have a language tagged predicate (example: name). Querying name should return only untagged values. name@. should return any language. Consider dataset <1> <name> "first user" . <2> <name@en> "second user" . query (func: uid(1,2)) { uid name} would return "{uid: 1, name: first user}". query (func: uid(1,2)) { uid name@.} would return "{{uid: 1, name@.: "first user"}, {uid: 2, name@.: "second user"}}". However due to a bug, we are not enforcing this in @filter(has(name)). So this results in query (func: has(dgraph.type)) @filter(has(name)) { uid name} results in "{{uid: 1, name: "first user'}, {uid: 2}}" Fix: We update @filter(has(name)) to filter on basis of language. Fixes: https://linear.app/hypermode/issue/HYP-311/inconsistent-counts-using-has-at-root --------- Co-authored-by: Harshil Goel <harshil@dgraph.io>

@filter

Currently when we have a language tagged predicate (example: name). Querying name should return only untagged values. name@. should return any language. Consider dataset <1> <name> "first user" . <2> <name@en> "second user" . query (func: uid(1,2)) { uid name} would return "{uid: 1, name: first user}". query (func: uid(1,2)) { uid name@.} would return "{{uid: 1, name@.: "first user"}, {uid: 2, name@.: "second user"}}". However due to a bug, we are not enforcing this in @filter(has(name)). So this results in query (func: has(dgraph.type)) @filter(has(name)) { uid name} results in "{{uid: 1, name: "first user'}, {uid: 2}}" Fix: We update @filter(has(name)) to filter on basis of language. Fixes: https://linear.app/hypermode/issue/HYP-311/inconsistent-counts-using-has-at-root --------- Co-authored-by: Harshil Goel <harshil@dgraph.io>

We don't need to use govendor here. All the deps are checked in.

7c99823

manishrjain assigned pawanrawal May 17, 2016

manishrjain added the kind/maintenance Maintenance tasks, such as refactoring, with no impact in features. label May 17, 2016

manishrjain added this to the v0.3 milestone May 17, 2016

manishrjain merged commit 7c99823 into master May 17, 2016

manishrjain deleted the dmuts branch May 17, 2016 09:11

manishrjain added the kind/maintenance Maintenance tasks, such as refactoring, with no impact in features. label Mar 22, 2018

shivaji-dgraph added a commit that referenced this pull request Feb 8, 2023

fixed Mutation request stuck when --limit flag is set #87

9c3a1e2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

We don't need to use govendor in Docker. All the deps are checked in. #87

We don't need to use govendor in Docker. All the deps are checked in. #87

manishrjain commented May 17, 2016 •

edited

Loading

pawanrawal commented May 17, 2016

We don't need to use govendor in Docker. All the deps are checked in.

We don't need to use govendor in Docker. All the deps are checked in. #87

We don't need to use govendor in Docker. All the deps are checked in. #87

Conversation

manishrjain commented May 17, 2016 • edited Loading

pawanrawal commented May 17, 2016

We don't need to use govendor in Docker. All the deps are checked in.

manishrjain commented May 17, 2016 •

edited

Loading