Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(dql): add workflow for fuzz testing #8874

Merged
merged 1 commit into from
Jun 15, 2023
Merged

ci(dql): add workflow for fuzz testing #8874

merged 1 commit into from
Jun 15, 2023

Conversation

mangalaman93
Copy link
Contributor

Description: updates the fuzz testing to use the go fuzz framework
Closes: DGRAPHCORE-107

@mangalaman93 mangalaman93 mentioned this pull request Jun 14, 2023
Closed
@dgraph-bot dgraph-bot added area/integrations Related to integrations with other projects. area/querylang Issues related to the query language specification and implementation. area/testing Testing related issues go Pull requests that update Go code labels Jun 14, 2023
@mangalaman93 mangalaman93 force-pushed the aman/fuzz branch 4 times, most recently from 6b227ec to 8b48718 Compare June 14, 2023 03:33
@github-actions
Copy link

Fuzz test failed on 8b48718. Using the GitHub CLI, download the seed corpus with

gh run download 5262773680 -n testdata

@mangalaman93 mangalaman93 force-pushed the aman/fuzz branch 2 times, most recently from 35a7617 to 0557f38 Compare June 14, 2023 03:36
@github-actions
Copy link

Fuzz test failed on commit 0557f38. To troubleshoot locally, use the GitHub CLI to download the seed corpus with

gh run download 5262793291 -n testdata

@github-actions
Copy link

Fuzz test failed on commit e61abef. To troubleshoot locally, use the GitHub CLI to download the seed corpus with

gh run download 5262803271 -n testdata

@mangalaman93 mangalaman93 force-pushed the aman/fuzz branch 2 times, most recently from 35e696f to 9d86c52 Compare June 14, 2023 03:48
joshua-goldstein
joshua-goldstein reviewed Jun 14, 2023
View reviewed changes
Copy link
Contributor

@joshua-goldstein joshua-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I suggest changing the name of the file to ci-dgraph-fuzz.yml and the name of the workflow to ci-dgraph-fuzz to be consistent with the other workflows. Also helps distinguish e.g. if we add a workflow for fuzz testing in badger.

.github/workflows/ci-fuzz.yml Outdated Show resolved Hide resolved
@joshua-goldstein joshua-goldstein self-requested a review June 15, 2023 07:06
@mangalaman93 mangalaman93 merged commit fe90b32 into main Jun 15, 2023
@mangalaman93 mangalaman93 deleted the aman/fuzz branch June 15, 2023 07:43
dgraph-bot pushed a commit that referenced this pull request Jul 7, 2023
@mangalaman93 @dgraph-bot
ci(dql): add workflow for fuzz testing (#8874)
9c9643e 
Description: updates the fuzz testing to use the go fuzz framework
Closes: DGRAPHCORE-107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshil-goel harshil-goel harshil-goel approved these changes

@joshua-goldstein joshua-goldstein joshua-goldstein approved these changes

@akon-dey akon-dey Awaiting requested review from akon-dey

@darkn3rd darkn3rd Awaiting requested review from darkn3rd

@meghalims meghalims Awaiting requested review from meghalims

@matthewmcneely matthewmcneely Awaiting requested review from matthewmcneely

@billprovince billprovince Awaiting requested review from billprovince

Assignees
No one assigned
Labels
area/integrations Related to integrations with other projects. area/querylang Issues related to the query language specification and implementation. area/testing Testing related issues go Pull requests that update Go code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mangalaman93 @harshil-goel @joshua-goldstein @dgraph-bot