Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): add feature flag normalize-compatibility-mode (#8845) #8929

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

mangalaman93
Copy link
Contributor

@mangalaman93 mangalaman93 commented Aug 3, 2023

This feature flag allows configuring @normalize in the query language such that if there are multiple fields with same alias, they could be returned as a list or non-list.

There was a breaking change at some point with the PR #7639. Some customers do not prefer a list response in case of @normalize. We would like to not make any breaking changes going forward, and hence, introducing this feature flag enables users to make that choice.

@dgraph-bot dgraph-bot added area/testing Testing related issues area/core internal mechanisms go Pull requests that update Go code labels Aug 3, 2023
@mangalaman93 mangalaman93 force-pushed the aman/ff branch 2 times, most recently from 12718e9 to e74c3d8 Compare August 4, 2023 12:55
Copy link
Contributor

@sanjayk-github-dev sanjayk-github-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make sure that the "compatibility-mode" output matches what "Connect America" is currently seeing with their specific Dgraph version.

This feature flag allows configuring @normalize in the query language
such that if there are multiple fields with same alias, they could be
returned as a list or non-list.

There was a breaking change at some point with the PR
#7639. Some customers do not
prefer a list response in case of @normalize. We would like to not make
any breaking changes going forward, and hence, introducing this feature
flag enables users to make that choice.
@mangalaman93 mangalaman93 changed the title feat(query): add feature flag list-in-normalize (#8845) feat(query): add feature flag normalize-compatibility-mode (#8845) Aug 4, 2023
@mangalaman93 mangalaman93 merged commit 3d5080f into main Aug 8, 2023
11 checks passed
@mangalaman93 mangalaman93 deleted the aman/ff branch August 8, 2023 19:53
jbhamra1 pushed a commit that referenced this pull request Aug 17, 2023
…8929)

This feature flag allows configuring @normalize in the query language
such that if there are multiple fields with same alias, they could be
returned as a list or non-list.

There was a breaking change at some point with the PR
#7639. Some customers do not
prefer a list response in case of @normalize. We would like to not make
any breaking changes going forward, and hence, introducing this feature
flag enables users to make that choice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core internal mechanisms area/testing Testing related issues go Pull requests that update Go code
Development

Successfully merging this pull request may close these issues.

4 participants