Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vector type to Dgraph #9050

Merged
merged 13 commits into from
Mar 19, 2024
Merged

Add vector type to Dgraph #9050

merged 13 commits into from
Mar 19, 2024

Conversation

harshil-goel
Copy link
Contributor

@harshil-goel harshil-goel commented Mar 13, 2024

No description provided.

@harshil-goel harshil-goel requested a review from a team as a code owner March 13, 2024 16:56
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Harshil Goel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dgraph-bot dgraph-bot added area/testing Testing related issues area/querylang Issues related to the query language specification and implementation. area/schema Issues related to the schema language and capabilities. area/core internal mechanisms go Pull requests that update Go code labels Mar 13, 2024
Copy link
Contributor

@mangalaman93 mangalaman93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check for coverage for the new changes using unit tests

protos/pb.proto Outdated Show resolved Hide resolved
protos/pb.proto Show resolved Hide resolved
query/math.go Outdated Show resolved Hide resolved
query/math_test.go Show resolved Hide resolved
schema/parse_test.go Outdated Show resolved Hide resolved
types/conversion.go Show resolved Hide resolved
types/conversion.go Outdated Show resolved Hide resolved
types/conversion.go Outdated Show resolved Hide resolved
types/value.go Outdated Show resolved Hide resolved
types/value.go Outdated Show resolved Hide resolved
protos/pb.proto Outdated Show resolved Hide resolved
protos/pb.proto Outdated Show resolved Hide resolved
protos/pb.proto Outdated Show resolved Hide resolved
query/aggregator.go Outdated Show resolved Hide resolved
query/aggregator.go Outdated Show resolved Hide resolved
query/aggregator.go Outdated Show resolved Hide resolved
query/aggregator.go Show resolved Hide resolved
query/outputnode.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
types/value.go Outdated Show resolved Hide resolved
query/aggregator.go Outdated Show resolved Hide resolved
query/common_test.go Outdated Show resolved Hide resolved
query/query0_test.go Show resolved Hide resolved
query/query0_test.go Outdated Show resolved Hide resolved
types/conversion.go Show resolved Hide resolved
types/scalar_types.go Show resolved Hide resolved
mangalaman93
mangalaman93 previously approved these changes Mar 18, 2024
mangalaman93
mangalaman93 previously approved these changes Mar 19, 2024
@mangalaman93 mangalaman93 merged commit 1073f92 into main Mar 19, 2024
6 of 12 checks passed
@mangalaman93 mangalaman93 deleted the harshil-goel/vector-type branch March 19, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core internal mechanisms area/querylang Issues related to the query language specification and implementation. area/schema Issues related to the schema language and capabilities. area/testing Testing related issues go Pull requests that update Go code
Development

Successfully merging this pull request may close these issues.

4 participants