This repository has been archived by the owner on May 21, 2022. It is now read-only.
Added logic to MapClaims to allow 'aud' to be an array of strings #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@dgrijalva why this is not merged? or you want to first move to new release? |
|
This is a critical feature for me. A common pattern in OIDC is to append a |
SVilgelm
suggested changes
Nov 20, 2019
| func verifyAud(aud string, cmp string, required bool) bool { | ||
| if aud == "" { | ||
| func verifyAud(auds []string, cmp string, required bool) bool { | ||
| if auds == nil || len(auds) == 0 { |
There was a problem hiding this comment.
auds == nil is not necessary, len(auds) covers both cases: https://play.golang.org/p/rzZoRNYYo9N
| aud, _ := m["aud"].(string) | ||
| var aud []string | ||
| switch exp := m["aud"].(type) { | ||
| case string: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JWT spec allows "aud" to be either a single string or an array of strings. This change should be backward compatible with previous versions.