[COPP]Fix coppmgr when there are multiple features using same trap #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivekrnv
reviewed
May 10, 2024
| @@ -183,14 +183,13 @@ bool CoppMgr::isTrapIdDisabled(string trap_id) | |||
| { | |||
| return false; | |||
| } | |||
| break; | |||
| if (isFeatureEnabled(trap_name)) | |||
There was a problem hiding this comment.
So basically, to install a Trap we are checking if any of the dependent features are enabled. Previously the assumption is a 1<->1 mapping between trap and feature. Correct me if i'm wrong
There was a problem hiding this comment.
Correct. Now if any feature containing the trap is enabled the trap should be installed. Recently there is a new feature pac which uses eapol trap same as macsec. But if macsec is not enabled this feature didn't work as trap is getting installed with only macsec. With this change the issue will be resolved.
vivekrnv
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix coppmgr when there are multiple feature tables using same trap.
In addition fixed the following issues
Why I did it
Fix copp issues
How I verified it
Added UT to verify
Details if related