-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use appveyor to build, test and deploy in windows #785
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just one question
Would it be possible to run the Appveyor build on all pull requests? |
Yeah, it builds by default pull requests!, but without cache. I think we could activate it, right? |
It can only be activate in the web ui for the project:
|
@jneira: Could we verify that by having it build this pull request? |
@Gabriel439 yeah! we need to install the appveyor app in this repo to test it, but you can view it in this pr in my fork: jneira#3 |
Have you received the request to install the appveyor github app? The builds will be triggered only for master, any branch containing |
@jneira: I just approved the request. However, is there any reason we we would not want to build all pull requests? The way that the Hydra CI works is that it builds the |
@Gabriel439 I have not been precise: in fact it will build master, branch with appveyor, tags and all pull requests. Moreover, it will read the cache for pull request, only write cache from pull requests is optional. |
Appveyor is building this! Thanks for the setup, @Gabriel439 |
You're welcome! This is good to merge now |
Hi, to adress #627 i've tested a build script using appveyor ci. Overview:
stack.yaml
(currentlylts-13
) andstack-lts-6.yaml
lts-6
dhall-json cannot be built cause it usesApplicativeDo
so i have to skip itstack.yaml
dhall:doctests
cause throws spurious errors due to encoding. I've not found a way to avoid them like in local (setting encoding of console to utf-8)stack-lts-6.yaml
cause stack is not able to build test dependencies for dhall (at least i've not found a way to make it work, althoughcabal
is able to do it)appveyor
or tags (and for pull requests)stack.yaml
, adding them to the release if it already exists.