Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyPI: relative links in README.md break in long_description #12

Closed
colinkcurtis opened this issue Feb 20, 2019 · 3 comments
Closed

PyPI: relative links in README.md break in long_description #12

colinkcurtis opened this issue Feb 20, 2019 · 3 comments

Comments

@colinkcurtis
Copy link

I just wanted to give you a heads up that the link: https://pypi.org/project/obonet/examples/go-obonet.ipynb ( which is located at https://pypi.org/project/obonet/ ) is currently returning a 404.
@dhimmel dhimmel changed the title broken ipynb link for obonet PyPI: relative links in README.md break in long_description Feb 20, 2019
@dhimmel
Copy link
Owner

dhimmel commented Feb 20, 2019

The issue is that README.md uses relative links. I'll see if there is a good workaround so we can keep the relative links but expand them for setup.py's long_description argument, which is how the README gets set for PyPI. If not, I'll probably leave the links broken, since I think value relative links in the repository over perfection on PyPI.

@dhimmel
Copy link
Owner

dhimmel commented Feb 20, 2019

Similar issue to pysal/pointpats#8 / hypatia-software-org/hypatia-engine#124 / senaite/senaite.sync#61

@dhimmel
Copy link
Owner

dhimmel commented Feb 21, 2019

In 5eaafa8 I switched to absolute links, following the lead of the other projects in the previous comment. However, the links were still broken (for another reason, fixed in 12ae7d6). Now, the links are finally fixed on PyPI as of v0.2.5. See https://pypi.org/project/obonet/0.2.5/

Thanks @colinkcurtis for the initial report!

@delhomer delhomer mentioned this issue May 14, 2020
Closed
@dbeatty10 dbeatty10 mentioned this issue Jan 5, 2021
Open
@hirosassa hirosassa mentioned this issue Jan 9, 2022
Closed
garymm added a commit to garymm/onnx that referenced this issue Jan 22, 2022
@garymm
Clean up README
8902333 
* Trim trailing space
* Use relative links. Absolute links were needed because of
  <dhimmel/obonet#12>, which is fixed now.
* Fix typos.
* master -> main.

Signed-off-by: Gary Miguel <garymiguel@microsoft.com>
@garymm garymm mentioned this issue Jan 22, 2022
Merged
garymm added a commit to garymm/onnx that referenced this issue Jan 22, 2022
@garymm
Clean up README
f5a9fb0 
* Trim trailing space
* Use relative links. Absolute links were needed because of
  <dhimmel/obonet#12>, which is fixed now.
* Fix typos.
* master -> main.

Signed-off-by: Gary Miguel <garymiguel@microsoft.com>
askhade pushed a commit to onnx/onnx that referenced this issue Jan 22, 2022
@garymm
Clean up README (#3961)
bd5883a 
* Trim trailing space
* Use relative links. Absolute links were needed because of
  <dhimmel/obonet#12>, which is fixed now.
* Fix typos.
* master -> main.

Signed-off-by: Gary Miguel <garymiguel@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dhimmel @colinkcurtis