Skip to content

Commit

Permalink
chore: apply PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
Mohammer5 committed Jul 25, 2024
1 parent 6d9627c commit a7e246c
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 44 deletions.
6 changes: 1 addition & 5 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,2 @@
# The following files are yaml templates and produce SyntaxErrors with prettier
helm/chart/templates/deployment.yaml
helm/chart/templates/hpa.yaml
helm/chart/templates/ingress.yaml
helm/chart/templates/serviceaccount.yaml
helm/chart/templates/tests/test-connection.yaml
helm
18 changes: 1 addition & 17 deletions .prettierrc.cjs
Original file line number Diff line number Diff line change
@@ -1,21 +1,5 @@
// const { config } = require('@dhis2/cli-style')
// const defaultConfig = require(config.prettier)

// module.exports = {
// ...defaultConfig,
// printWidth: 180,
// overrides: [
// {
// files: '**/*.yml',
// options: {
// singleQuote: false,
// },
// },
// ],
// }

module.exports = {
printWidth: 80,
printWidth: 180,
tabWidth: 4,
useTabs: false,
semi: false,
Expand Down
42 changes: 20 additions & 22 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,30 +1,28 @@
# React + TypeScript + Vite
# Instance Manager Web Client

This template provides a minimal setup to get React working in Vite with HMR and some ESLint rules.
## Run the app locally

Currently, two official plugins are available:
1. `yarn`
2. `yarn start`

- [@vitejs/plugin-react](https://github.com/vitejs/vite-plugin-react/blob/main/packages/plugin-react/README.md) uses [Babel](https://babeljs.io/) for Fast Refresh
- [@vitejs/plugin-react-swc](https://github.com/vitejs/vite-plugin-react-swc) uses [SWC](https://swc.rs/) for Fast Refresh
## Run using docker compose

## Expanding the ESLint configuration

If you are developing a production application, we recommend updating the configuration to enable type aware lint rules:
```sh
make dev
```

- Configure the top-level `parserOptions` property like this:
## Run using skaffold

```js
export default {
// other rules...
parserOptions: {
ecmaVersion: 'latest',
sourceType: 'module',
project: ['./tsconfig.json', './tsconfig.node.json'],
tsconfigRootDir: __dirname,
},
}
```sh
skaffold dev
```

- Replace `plugin:@typescript-eslint/recommended` to `plugin:@typescript-eslint/recommended-type-checked` or `plugin:@typescript-eslint/strict-type-checked`
- Optionally add `plugin:@typescript-eslint/stylistic-type-checked`
- Install [eslint-plugin-react](https://github.com/jsx-eslint/eslint-plugin-react) and add `plugin:react/recommended` & `plugin:react/jsx-runtime` to the `extends` list
## Notes about fixed dependency versions

- `openapi-typescript@5.4.1` is used because later versions do not work with OpenAPI V2, which our backend is stuck on

## TODO

- Validate create group form
- Can submit without hostname... No effect, no error
- Loading shows within form

0 comments on commit a7e246c

Please sign in to comment.