Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow for fractional expiry days in datasets #18594

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

feat: Allow for fractional expiry days in datasets #18594

wants to merge 15 commits into from
+55 −19

Conversation

jason-p-pickering
Copy link
Contributor

@jason-p-pickering jason-p-pickering commented Sep 13, 2024 •
edited
Loading

jbee
jbee requested changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@jbee jbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing a flyway DB migration to update the column in dataset to allow floating point values.

@jason-p-pickering jason-p-pickering changed the title feat: Allow for fractional expiry days feat: Allow for fractional expiry days in datasets Sep 13, 2024
@jason-p-pickering
Copy link
Contributor Author

You are missing a flyway DB migration to update the column in dataset to allow floating point values.

Added a migration script.

@jason-p-pickering jason-p-pickering requested a review from a team September 13, 2024 06:51
david-mackessy
david-mackessy approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@david-mackessy david-mackessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOW flyway versioning doc should also be updated - https://github.com/dhis2/wow-backend/blob/master/coordination/flyway_versioning.md

@jason-p-pickering jason-p-pickering marked this pull request as draft September 13, 2024 10:04
@jason-p-pickering jason-p-pickering marked this pull request as ready for review September 16, 2024 08:34
@jason-p-pickering
Copy link
Contributor Author

You are missing a flyway DB migration to update the column in dataset to allow floating point values.

Added the flyway script.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbee jbee jbee approved these changes

@david-mackessy david-mackessy david-mackessy approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jason-p-pickering @jbee @david-mackessy