Bugfix: Items over 255 durability #5773
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kphoenix137
force-pushed
the
bugfix-high-durability-items
branch
from
3348e41
to
eddb5e7
Compare
StephenCWills
force-pushed
the
bugfix-high-durability-items
branch
from
eddb5e7
to
add9bb1
Compare
StephenCWills
previously approved these changes
Sep 30, 2023
|
Should it not be clamped to 254? |
|
Hm, maybe yes, if you assume #5772 won't be merged any time soon. I was kinda hoping it was close to ready, though I can't say I know what we should do about Oil of Permanence. |
|
approved, when merge? |
AJenbo
reviewed
Sep 15, 2024
See previous comments, or the one I just made. |
StephenCWills
dismissed
their stale review
Comments that need to be addressed
Co-authored-by: Anders Jenbo <anders@jenbo.dk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some items with the
of Structurepower can exceed 255 durability, causing the item to drop to a low durability when regenerated. This clamps the bonus given from the affix so that it doesn't exceed 255.