Single point version definition #285
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigerl
requested changes
Oct 1, 2024
| @@ -220,6 +220,7 @@ | |||
| <directory>${project.basedir}/src/main/resources/</directory> | |||
| <includes> | |||
| <include>start-iguana.sh</include> | |||
| <include>iguana.owx</include> | |||
There was a problem hiding this comment.
As just discussed, please have a separate version for the ontology. Please Also add an action that checks if the ontology was changed. If it was changed it should require to the ontology version to be raised and to be equal to the code version.
| @@ -220,6 +220,7 @@ | |||
| <directory>${project.basedir}/src/main/resources/</directory> | |||
| <includes> | |||
| <include>start-iguana.sh</include> | |||
| <include>iguana.owx</include> | |||
There was a problem hiding this comment.
Please also add the ontology version to iguana --version. Not sure if we defined the option yet. If not, please add.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versioning:
schema/iguana.owxtosrc/main/resources/iguana.owxand updated theversionIRIto use the${revision}placeholder (ontology version will be equal to the version of IGUANA)graalvm/generate-profile.shto remove hardcoded version numbers and use dynamic naming for instrumented and PGO builds.iguana.owxto the resources section inpom.xmlfor proper inclusion during the build process.Deployment Workflow Updates:
Cleanup