-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Blake2xb and LtHash #40
base: develop
Are you sure you want to change the base?
Conversation
with gcc-12 I get:
|
Thx for getting the basics set up. I managed to fix the test and example runs, but have no idea why the two failing actions are failing so would be nice if you could have a look at those two. Btw: needed to update to gcc11 and clang11 because gcc10 and clang10 were not able to build the project anymore. |
So, since integrating libsodium here directly turned out to be a little more problematic than anticipated, I instead added a flag to conditionally enable libsodium support (and therefore Blake2b, Blake2Xb and LtHash). The flag is called |
# Conflicts: # conanfile.py
# Conflicts: # conanfile.py
POBR diff fails, because i fixed the files to be checked by it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First review, mostly buildsystem related
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
highway stuff looks good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some stuff left
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good to go now.
Just to be extra sure: could you try if it works as a dependency in another library?
TODOs: (some of the stuff is probably more something for you, alex)
More general: