Skip to content

Commit

Permalink
remove finalizers
Browse files Browse the repository at this point in the history
Disposing of resources via finalizers is problematic due to parent/child
ordering enforced by the host.

Signed-off-by: Joel Dice <joel.dice@fermyon.com>
  • Loading branch information
dicej committed Sep 13, 2024
1 parent f58eecb commit 1cac496
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 10 deletions.
5 changes: 0 additions & 5 deletions src/InputStream.cs
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,6 @@ public InputStream(IStreams.InputStream stream)
this.stream = stream;
}

~InputStream()
{
Dispose(false);
}

public override bool CanRead => true;
public override bool CanWrite => false;
public override bool CanSeek => false;
Expand Down
5 changes: 0 additions & 5 deletions src/OutputStream.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,6 @@ public OutputStream(IStreams.OutputStream stream)
this.stream = stream;
}

~OutputStream()
{
Dispose(false);
}

public override bool CanRead => false;
public override bool CanWrite => true;
public override bool CanSeek => false;
Expand Down

0 comments on commit 1cac496

Please sign in to comment.