Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to Signed Statements for Hashed Payloads #5

Merged
merged 33 commits into from
Jul 20, 2024

Conversation

SteveLasker
Copy link

No description provided.

Documentation improvements
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
@SteveLasker SteveLasker marked this pull request as draft July 10, 2024 22:55
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
@SteveLasker SteveLasker marked this pull request as ready for review July 12, 2024 01:56
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
@SteveLasker
Copy link
Author

Signed-off-by: steve lasker <stevenlasker@hotmail.com>
scitt-scripts/entrypoint.sh Outdated Show resolved Hide resolved
# now create a sha256 hash of the payload
#
# NOTE: any hashing algorithm can be used.
payload_hash = sha256(payload.encode("utf-8")).digest()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future enhancement idea: fetch the payload at the payload location and compare its hash with the specified payload file hash

Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
@CBonnell CBonnell self-requested a review July 20, 2024 17:47
Copy link
Collaborator

@CBonnell CBonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @SteveLasker

@CBonnell CBonnell merged commit 08d08ee into digicert:main Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants