Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error messages / custom fastify errors to blob server plugin #252

Open
sethvincent opened this issue Sep 6, 2023 · 2 comments
Open
Labels
post-mvp de-scoped to after MVP

Comments

@sethvincent
Copy link
Contributor

As noted here there's not currently useful error messages returned from the blob-server endpoints.

It would be good to either:

  • add custom errors with error messages for usage in fastify
  • ensure that all reply usage includes error messages
@achou11
Copy link
Member

achou11 commented Sep 6, 2023

just some helpful context from Gregor in the case of serving blobs specifically:

Just to point out that since this server is serving images, error messages do not make a lot of sense, because we are not processing the response in JS code (the response is handled on the platform specific image component).

still think this is worth exploring otherwise

@gmaclennan gmaclennan added the post-mvp de-scoped to after MVP label Sep 7, 2023
@gmaclennan
Copy link
Member

Marking as post-mvp because I don't think this is necessary for MVP

@achou11 achou11 changed the title Add error messages / custom fastify errors to blob-server Add error messages / custom fastify errors to blob server plugin Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
post-mvp de-scoped to after MVP
Projects
None yet
Development

No branches or pull requests

3 participants