Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blobStore.createReadStream should not wait #243

Merged
merged 4 commits into from
Sep 6, 2023
Merged

blobStore.createReadStream should not wait #243

merged 4 commits into from
Sep 6, 2023

Conversation

sethvincent
Copy link
Contributor

This adds wait and timeout options to blobStore.createReadStream.

It adds those options to blobStore.createEntryReadStream as well.

closes #80

achou11
achou11 approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@achou11 achou11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of non-blocking questions but overall looks good!

src/blob-store/index.js Outdated Show resolved Hide resolved
tests/blob-server.js Outdated Show resolved Hide resolved
tests/blob-server.js Show resolved Hide resolved
@achou11
Copy link
Member

achou11 commented Sep 5, 2023

also noticing that some of the files haven't been formatted using npm run format. we should probably set up a pre-commit step for this but in the meantime, mind running that on the relevant files?

@sethvincent sethvincent mentioned this pull request Sep 6, 2023
Open
@sethvincent sethvincent merged commit f0d9e95 into main Sep 6, 2023
6 checks passed
@sethvincent sethvincent deleted the blobstore-createreadstream-options-#80 branch September 6, 2023 15:00
gmaclennan added a commit that referenced this pull request Sep 7, 2023
@gmaclennan
Merge branch 'main' into feat/device-info
80aef39 
* main:
  expose member namespace in MapeoProject (#253)
  blobStore.createReadStream should not wait (#243)
  update MapeoManager to return and handle project public IDs (#247)
  return content hash from blobApi.create (#242)
gmaclennan added a commit that referenced this pull request Sep 12, 2023
@gmaclennan
Merge branch 'main' into feat/haves-extension
4061434 
* main:
  feat: Add set & get deviceInfo & datatype (#250)
  expose member namespace in MapeoProject (#253)
  blobStore.createReadStream should not wait (#243)
  update MapeoManager to return and handle project public IDs (#247)
  return content hash from blobApi.create (#242)
gmaclennan added a commit that referenced this pull request Sep 19, 2023
@gmaclennan
Merge branch 'main' into feat/mdns-discovery
c5d88c4 
* main:
  chore: condense setup code in MemberAPI tests (#267)
  chore: replace queries opt in MemberAPI with dataType (#266)
  feat: add getMany method to member api (#263)
  feat: add getById method to member api (#262)
  chore: Update @digidem/types and remove patch (#269)
  feat: share all core keys via extension messages (#264)
  feat: send core "haves" bitfield on first connect (#254)
  fix: invite.encryptionKeys should be required (#260)
  feat: Add set & get deviceInfo & datatype (#250)
  expose member namespace in MapeoProject (#253)
  blobStore.createReadStream should not wait (#243)
  update MapeoManager to return and handle project public IDs (#247)
  return content hash from blobApi.create (#242)
This was referenced Nov 16, 2023
Closed
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Dec 4, 2023
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Dec 12, 2023
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Mar 14, 2024
Merged
This was referenced Apr 11, 2024
Merged
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Apr 30, 2024
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request May 9, 2024
Merged
This was referenced Jun 20, 2024
Merged
Merged
Merged
This was referenced Jul 25, 2024
Merged
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Aug 13, 2024
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Aug 21, 2024
Merged
This was referenced Aug 27, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 11, 2024
Closed
Merged
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achou11 achou11 achou11 approved these changes

@gmaclennan gmaclennan Awaiting requested review from gmaclennan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

blobStore.createReadStream() should not "wait"
3 participants
@sethvincent @achou11 @gmaclennan