Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin pre-release deps #343

Closed
gmaclennan opened this issue Oct 20, 2023 · 0 comments · Fixed by #344
Closed

pin pre-release deps #343

gmaclennan opened this issue Oct 20, 2023 · 0 comments · Fixed by #344

Comments

@gmaclennan
Copy link
Member

Description

By default it seems that "^1.0.0-alpha.6" will resolve to "1.0.0-alpha.7" if it is published. I had not realized this was how npm resolution works, and we publish breaking changes in new alpha versions. To avoid issues when consuming this module, we should pin alpha releases (this is why @mapeo/core@1.0.0-alpha.1 is broken, because it is using @mapeo/sqlite-indexer@1.0.0-alpha.7, but the code published is written for v1.0.0-alpha.6)
gmaclennan added a commit that referenced this issue Oct 20, 2023
@gmaclennan
fix: pin pre-releases to exact version
7b73caa 
Fixes pin pre-release deps #343
@gmaclennan gmaclennan mentioned this issue Oct 20, 2023
Merged
@gmaclennan gmaclennan linked a pull request Oct 20, 2023 that will close this issue
fix: pin pre-releases to exact version #344
Merged
gmaclennan added a commit that referenced this issue Oct 22, 2023
@gmaclennan
fix: pin pre-releases to exact version (#344)
bbdccfa 
Fixes pin pre-release deps #343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: pin pre-releases to exact version digidem/comapeo-core
1 participant
@gmaclennan