feat: add invite namespace to MapeoManager #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achou11
force-pushed
the
212/manager-invite-namespace
branch
from
7b09eb5
to
b05a461
Compare
achou11
commented
Sep 25, 2023
There was a problem hiding this comment.
although this file is not included in the tsconfig, it gets required by a file that does (test-e2e/...) so TS picks it up and complains about type errors. needed to address as a result
gmaclennan
approved these changes
Sep 28, 2023
This was referenced Nov 16, 2023
This was referenced Apr 11, 2024
This was referenced Jun 20, 2024
This was referenced Jul 25, 2024
This was referenced Aug 21, 2024
This was referenced Aug 29, 2024
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #212
There are some commented-out test assertions that would be nice to have but I think we're missing some pieces related to sync in order to do that. Could be mistaken though...