Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix usage of drizzle when core is used as a dep #283

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

achou11
Copy link
Member

@achou11 achou11 commented Sep 26, 2023

Towards #278

Attempting to use @mapeo/core as a dep in a separate project breaks because:

  1. We don't include the drizzle migration directories when publishing

  2. The path string we provide to drizzle's migrate() function is not absolute, which breaks when this is being used as dependency (implementation of how Drizzle attempts to find the migration files based on the provided path is here)

I encountered these by using npm pack on this repo and then importing as a dep in separate project

@achou11 achou11 mentioned this pull request Sep 26, 2023
2 tasks
@achou11 achou11 merged commit 2dfa016 into main Sep 27, 2023
6 checks passed
@achou11 achou11 deleted the ac/drizzle-config-fixes branch September 27, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants