-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use drive discovery key for drive ids #294
use drive discovery key for drive ids #294
Conversation
6547df3
to
ee55c5b
Compare
implementation now just updates what the driveId represents
ee55c5b
to
52ab62b
Compare
This reverts commit 52ab62b.
473a3b6
to
10af756
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Not sure about the naming question. Internally, it makes sense that it is called driveDiscoveryId
, since that describes what it is, but for the API consumer, I think driveId
makes sense, because for the API consumer it is just "ID that identities the drive the blob is stored on", and we don't expose any other ID to the API consumer.
In summary, I think maybe call it driveId
where the API consumer sees it, even though that makes it a little confusing when reading the internals - just make sure to add comments.
yeah all of that came to mind as I was implementing. One question I have then is should the return value of EDIT: leaning towards |
This reverts commit 10af756.
Decided to basically revert the renaming entirely, without attempting to strategically update naming for internals. Just became confusing and I think for now the comments are helpful enough. Can revisit if it really does become super confusing |
* update dep * update project database * update client database * fix errors caused by coreDiscoveryId naming * fix errors caused by deleted field * use drive discovery key for drive ids (#294) * add `Icon` table and dataType, regenerate drizzle * update `mapeo-schema` to `next.11` * add `icon` to datastore's config namespace * merge fix --------- Co-authored-by: Andrew Chou <andrewchou@fastmail.com> Co-authored-by: Tomás Ciccola <tciccola@digital-democracy.com>
Closes #272
Stacked on #290
This PR:
driveId
field of theBlobId
type todriveDiscoveryId
, to align with the issue's desire to update the observation attachment reference.I initially thought we may want to rename
driveId
used in the blobs-related code todriveDiscoveryId
but then realized that we may not want that. If we want to revert the naming, just a matter of reverting the last commit on this PR.