chore: update sodium-native to latest #338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achou11
force-pushed
the
chore/update-sodium-native
branch
from
3a1191d
to
95a3d12
Compare
|
the failing CI is a concern here 🤔 seems way flakier than usual - maybe this upgrade does break something?? |
achou11
force-pushed
the
chore/update-sodium-native
branch
from
95a3d12
to
9bda2dd
Compare
|
seems like this is causing some of the discovery/mdns tests to fail. kind of surprised since it doesn't look like they changed the underlying libsodium version that's being used 🤔 @gmaclennan any ideas? |
|
Replaced by #328 which fixes CI errors from tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar reasoning as #337
Updates sodium-native (used by sodium-universal) from 4.0.1 to 4.0.4