rename MapeoManager.start() and MapeoManager.stop() methods #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
gmaclennan
approved these changes
Nov 30, 2023
| coreStorage: () => new RAM(), | ||
| }) | ||
|
|
||
| await manager.startMediaServer() |
There was a problem hiding this comment.
Check it's started: get a url, check it works.
There was a problem hiding this comment.
Don't need to put data there, just returning 404 is enough to know it's started.
| }) | ||
|
|
||
| await manager.startMediaServer() | ||
| await manager.startMediaServer() |
There was a problem hiding this comment.
get a url, check the port hasn't changed
|
|
||
| await manager.startMediaServer() | ||
| await manager.startMediaServer() | ||
| await manager.stopMediaServer() |
There was a problem hiding this comment.
check the url previously returned no longer works (should return a connection error)
test-e2e/media-server.js
Outdated
Comment on lines
36
to
76
| await manager.startMediaServer() | ||
| await manager.stopMediaServer() |
achou11
force-pushed
the
ac/manager-start-stop-rename
branch
from
1127de5
to
876b628
Compare
addressed in 876b628 |
This was referenced Apr 11, 2024
This was referenced Jun 20, 2024
This was referenced Jul 25, 2024
This was referenced Aug 21, 2024
This was referenced Aug 29, 2024
This was referenced Sep 2, 2024
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #391
Renames them to
startMediaServer()andstopMediaServer(), respectively