chore: invite API's membership check can be synchronous #480
Conversation
This change should have no user impact. This function doesn't do anything async so we can make it synchronous. I think this is a useful change on its own but will make upcoming changes a bit simpler.
|
There is one thing missing from the existing implementation that is asynchronous: project membership also has a "joining" state, eg a user has accepted an invite but has not finished adding the project, eg if they do not receive back the project join details, or the add project method fails for some reason. Ideally other invites would await the joining state rather than treat it as an "already joined" state. I think it's ok to ignore that state for now, but making this asynchronous just leaves more work when we try to add it back. I'm ok with that as long as we don't get ourselves into a corner where we make it really hard to deal with this edge case in the future. |
|
Good point. I'll make sure to do that in my upcoming work (#447). In any case, I still think it makes sense for this to be synchronous because I don't think the "joining" state would be stored here. |
This change should have no user impact.
This function doesn't do anything async so we can make it synchronous. I think this is a useful change on its own but will make upcoming changes (#447) a bit simpler.