Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/manual gps when no location service #702

Merged
merged 4 commits into from
Sep 16, 2024
Merged

Fix/manual gps when no location service #702

merged 4 commits into from
Sep 16, 2024

Conversation

ErikSin
Copy link
Contributor

@ErikSin ErikSin commented Sep 12, 2024

fixes: #685

image

achou11
achou11 requested changes Sep 16, 2024
View reviewed changes
src/frontend/screens/ObservationCreate/index.tsx Outdated Show resolved Hide resolved
src/frontend/screens/ObservationCreate/index.tsx Outdated Show resolved Hide resolved
src/frontend/screens/ObservationCreate/index.tsx Outdated Show resolved Hide resolved
src/frontend/screens/ObservationCreate/index.tsx Outdated Show resolved Hide resolved
achou11
achou11 requested changes Sep 16, 2024
View reviewed changes
src/frontend/screens/ObservationCreate/index.tsx Outdated Show resolved Hide resolved
src/frontend/screens/ObservationCreate/index.tsx Outdated Show resolved Hide resolved
src/frontend/screens/ObservationCreate/index.tsx Outdated Show resolved Hide resolved
src/frontend/screens/ObservationCreate/index.tsx Outdated Show resolved Hide resolved
src/frontend/screens/ObservationCreate/index.tsx Outdated Show resolved Hide resolved
@ErikSin
Copy link
Contributor Author

ErikSin commented Sep 16, 2024

Ok! i have tested it out on my device and it is doing what it should be doing: Asking for GPS when accuracy is greater than 10 and saving otherwise

achou11
achou11 approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@achou11 achou11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to update this PR with develop first since there have been some changes introduced (although no merge conflicts it seems)

@achou11
Copy link
Member

achou11 commented Sep 16, 2024

Also should update the PR title before merging!

@ErikSin ErikSin force-pushed the fix/manual-gps-when-no-location-service branch from 9ed6b36 to e300a95 Compare September 16, 2024 19:54
@ErikSin ErikSin merged commit 8a4935e into develop Sep 16, 2024
3 checks passed
@ErikSin ErikSin deleted the fix/manual-gps-when-no-location-service branch September 16, 2024 20:02
ErikSin added a commit that referenced this pull request Sep 16, 2024
@ErikSin
fix: manual gps prompt when no location service or innacurate location (
7817356 
#702)

* fix: prompts user to manually add gps when no or inaccurate location

* chore: translations

* chore: small fixes

* chore: pr fixes
@ErikSin ErikSin mentioned this pull request Sep 16, 2024
Merged
ErikSin added a commit that referenced this pull request Sep 16, 2024
@ErikSin
fix: manual gps prompt when no location service or innacurate location (
65bbd67 
#702) (#719)

* fix: prompts user to manually add gps when no or inaccurate location

* chore: translations

* chore: small fixes

* chore: pr fixes
This was referenced Sep 17, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achou11 achou11 achou11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Location not shared/ Cant save manual GPS
2 participants
@ErikSin @achou11